Skip to content

fix: 1.1.15 support emmc filewrite in boot #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 10, 2025
Merged

fix: 1.1.15 support emmc filewrite in boot #93

merged 2 commits into from
Oct 10, 2025

Conversation

wabicai
Copy link
Contributor

@wabicai wabicai commented Sep 28, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores

    • Upgraded OneKey SDK packages to v1.1.15 to align with the latest hardware libraries.
    • Updated hardware connection source to point at the newer SDK endpoint.

  • Notes

    • No user-facing behavior changes expected.
    • This improves compatibility and reliability with the latest hardware SDK releases.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 28, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

Updated OneKey SDK packages from 1.1.13 to 1.1.15 and changed the HardwareSDK connectSrc URL to the matching 1.1.15 endpoint. No API, signature, or control-flow changes.

Changes

Cohort / File(s) Summary
Dependency version bumps
package.json		 Bumped @onekeyfe/hd-core, @onekeyfe/hd-shared, and @onekeyfe/hd-web-sdk from 1.1.13 to 1.1.15.
Hardware SDK endpoint update
src/hardware/instance.ts		 Updated HardwareSDK initialization to use the connectSrc URL pointing to the 1.1.15 endpoint; other init parameters unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title promises a bug fix for eMMC file writing in boot mode but the diff only updates SDK versions without any emmc or boot logic changes, making the title misleading. Rename the title to reflect the actual change, for example “chore: bump OneKey SDK to 1.1.15-alpha.0,” or add the missing eMMC filewrite code to match the intent.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 8b51b1c and 86b40c1.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json (1 hunks)
  • src/hardware/instance.ts (1 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@revan-zhang
Copy link
Contributor

revan-zhang commented Sep 28, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

@socket-security Socket Security
Copy link

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updated@​onekeyfe/​hd-transport@​1.1.13 ⏵ 1.1.15-alpha.0100 +17100100 +18100 +4100
Updated@​onekeyfe/​hd-core@​1.1.13 ⏵ 1.1.15-alpha.0100100100100100
Updated@​onekeyfe/​hd-shared@​1.1.13 ⏵ 1.1.15-alpha.0100 +20100100 +28100 +4100
Updated@​onekeyfe/​hd-transport-http@​1.1.13 ⏵ 1.1.15-alpha.0100100100100100
Updated@​onekeyfe/​hd-transport-web-device@​1.1.13 ⏵ 1.1.15-alpha.0100100100100100
Updated@​onekeyfe/​hd-web-sdk@​1.1.13 ⏵ 1.1.15-alpha.0100100100100100

View full report

@wabicai wabicai enabled auto-merge (squash) September 28, 2025 09:12
coderabbitai[bot]
coderabbitai bot reviewed Sep 28, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2e8cdd7 and 8b51b1c.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • package.json (1 hunks)
  • src/hardware/instance.ts (1 hunks)

@wabicai wabicai changed the title fix: 1.1.15-alpha.0 support emmc filewrite in boot fix: 1.1.15 support emmc filewrite in boot Oct 10, 2025
@wabicai wabicai merged commit 7882efd into main Oct 10, 2025
9 of 10 checks passed
@wabicai wabicai deleted the fix/support-emmcwrite branch October 10, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@ByteZhang1024 ByteZhang1024 ByteZhang1024 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wabicai @revan-zhang @ByteZhang1024